Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task/enum update #174

Merged
merged 5 commits into from
Dec 17, 2024
Merged

Task/enum update #174

merged 5 commits into from
Dec 17, 2024
+84 −0

Conversation

mauerk
Copy link
Member

@mauerk mauerk commented Dec 17, 2024 •
edited
Loading

Fixes issue (if applicable) #

Proposed Changes

  • added IDAT to ResearchDataFileFormatEnum
  • updated FlowCellTypeEnum
  • updated LibraryPreparationKitRetailNameEnum

Checks

  • Builds locally

PMenges
PMenges previously approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@PMenges PMenges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for adding IDAT file enum! 👍
This closes issue:
#170

sbilge
sbilge requested changes Dec 17, 2024
View reviewed changes
Copy link
Member

@sbilge sbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Just a minor comment about one newly added enum.

src/schema/submission.yaml Outdated Show resolved Hide resolved
@mauerk mauerk requested review from PMenges and sbilge December 17, 2024 13:48
@mauerk mauerk merged commit 70e56b8 into main Dec 17, 2024
4 checks passed
@mauerk mauerk deleted the task/enum_update branch December 17, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandhi-iyappan anandhi-iyappan anandhi-iyappan approved these changes

@sbilge sbilge sbilge approved these changes

@PMenges PMenges PMenges approved these changes

@tanavader0 tanavader0 Awaiting requested review from tanavader0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mauerk @PMenges @sbilge @anandhi-iyappan