Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add event exception None test #61799

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

jangjodi
Copy link
Member

This #60885 caused an error since event.data["exception"] could be None. Add a test to make sure this is tested

closes #61798

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #61799 (a3f0301) into master (bf01f67) will increase coverage by 0.04%.
Report is 12 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #61799      +/-   ##
==========================================
+ Coverage   81.15%   81.19%   +0.04%     
==========================================
  Files        5188     5187       -1     
  Lines      228511   228371     -140     
  Branches    38322    38308      -14     
==========================================
- Hits       185437   185436       -1     
+ Misses      37439    37295     -144     
- Partials     5635     5640       +5     
Files Coverage Δ
...c/app/components/events/interfaces/nativeFrame.tsx 56.06% <ø> (+0.83%) ⬆️

... and 15 files with indirect coverage changes

@jangjodi jangjodi merged commit b379ec8 into master Dec 15, 2023
48 checks passed
@jangjodi jangjodi deleted the jodi/add-event-exception-none-test branch December 15, 2023 16:37
@github-actions github-actions bot locked and limited conversation to collaborators Dec 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add event exception None test
3 participants