-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(grouping): Group chunk load errors #60885
Conversation
🚀 Sentry Issue ReportYou modified these files in this pull request and we noticed these issues associated with them. 📄 src/sentry/event_manager.py
Did you find this useful? React with a 👍 or 👎 or let us know in #proj-github-pr-comments |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #60885 +/- ##
==========================================
- Coverage 81.13% 81.12% -0.01%
==========================================
Files 5191 5193 +2
Lines 228146 228255 +109
Branches 38262 38277 +15
==========================================
+ Hits 185103 185175 +72
- Misses 37425 37464 +39
+ Partials 5618 5616 -2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start! I've highlighted a bunch of small things, but overall I think the logic is sound. (It kinda sucks that we have to brute-force it this way, but until we decide on a more general way to handle weird cases like this, I think it's what we're left with.)
# Only check for the flag after it is established if it's a ChunkLoadError to avoid | ||
# unnecessary querying |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good thinking!
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
PR reverted: b9c7b73 |
This reverts commit 4b3d311. Co-authored-by: jangjodi <[email protected]>
Group node ChunkLoadErrors based on their message
fixes #57458