feat(node): Add monitor upsert types #7914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
a team,
mydea and
lforst
and removed request for
a team
lforst
reviewed
Apr 20, 2023
| } | ||
|
|
||
| type MonitorSchedule = CrontabSchedule | IntervalSchedule; | ||
|
|
||
| // https://develop.sentry.dev/sdk/check-ins/ | ||
| export interface CheckIn { |
There was a problem hiding this comment.
wondering why we have snake case in this type. I guess it saves us logic and size not having to map.
There was a problem hiding this comment.
yeah I don't want to write a toJSON to similar, but we might end up adopting it if needed (we do have Session vs. SerializedSession type for ex.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://develop.sentry.dev/sdk/check-ins/#schedule-configuration
ref: getsentry/sentry#43661, #7777
Add types for monitor upsert, and adjust tests accordingly.
Again we're not exposing these APIs, just having the types around so we can add it whenever.