Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): Add checkin envelope types #7777

Merged
merged 3 commits into from
Apr 7, 2023
Merged

Conversation

AbhiPrasad
Copy link
Member

ref getsentry/sentry#43661

I had some time on my hands, so added this in. Does not add any functionality around sending check-ins, only the envelope types needed to construct them.

https://develop.sentry.dev/sdk/check-ins/

I overengineered envelope types 😭

@AbhiPrasad AbhiPrasad requested review from a team, mydea and lforst and removed request for a team April 6, 2023 13:27
@AbhiPrasad AbhiPrasad changed the title feat(node): Add checkin envelope feat(node): Add checkin envelope types Apr 6, 2023
@AbhiPrasad AbhiPrasad self-assigned this Apr 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.94 KB (+0.08% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 65.44 KB (+0.03% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.49 KB (+0.07% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 57.88 KB (+0.04% 🔺)
@sentry/browser - Webpack (gzipped + minified) 21.11 KB (+0.06% 🔺)
@sentry/browser - Webpack (minified) 68.87 KB (+0.03% 🔺)
@sentry/react - Webpack (gzipped + minified) 21.14 KB (+0.07% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 48.9 KB (+0.03% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.5 KB (+0.06% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.73 KB (+0.06% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44.92 KB (0%)
@sentry/replay - Webpack (gzipped + minified) 38.87 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 63.82 KB (+0.03% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 56.85 KB (+0.03% 🔺)

packages/node/src/checkin.ts Outdated Show resolved Hide resolved
packages/node/src/checkin.ts Show resolved Hide resolved
@AbhiPrasad AbhiPrasad merged commit a2cda4d into develop Apr 7, 2023
@AbhiPrasad AbhiPrasad deleted the abhi-checkin-envelope branch April 7, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants