-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v5.0.0 #1919
Conversation
@HazAT Why not keep |
hey @benvinegar :)
So with that change we really only remove implicit internal functionality, since the only call to Instead now we set the Keeping this as a |
If I'm running 4.x, and I install 5.x, under what conditions will I have to change my code (public async API)? |
@benvinegar There are no code changes needed, the "Static API" didn't change. Sentry.init({dsn: "DSN"});
Sentry.captureException(new Error('test')); // This was never a promise Internally if you created your own const client = new Browser_Client({dsn: "DSN"});
client.captureException(new Error('test')); // <- this no longer returns a promise the API of |
…PIs (#1858) * ref: Move PromiseBuffer and Error to utils package * ref: Remove all async api * ref: Remove invokeClientAsync function * feat: Finish Node SDK * feat: SyncPromise implementation * fix: Browser SDK * fix: beforeSend callback * fix: Core tests * fix: linting and tests * fix: browser npm package + add error for manual tests * meta: Remove deprecations * fix: Typedocs and public exposed functions * meta: Changelog * Apply suggestions from code review
* fix: Events created from exception shouldnt have top-level message attribute (#1831) * Use SyncPromise internally & Remove deprecated API & Trim Public API (#1858) * ref: Move PromiseBuffer and Error to utils package * ref: Remove all async api * ref: Remove invokeClientAsync function * feat: Finish Node SDK * feat: SyncPromise implementation * fix: Browser SDK * fix: beforeSend callback * fix: Core tests * fix: linting and tests * fix: browser npm package + add error for manual tests * meta: Remove deprecations * fix: Typedocs and public exposed functions * meta: Changelog * Apply suggestions from code review * ref: Move public interfaces to types package * fix: Tests * fix: Small type issues * ref: Remove scope listeners * fix: Add flush to interface * ref: Remove interfaces from core
* ref: Move ExtendedError to a types package * ref: Remove assign util in favor of Object.assign * ref: Pass Event to sendEvent instead of just a body * ref: Remove isArray and isNaN utils * ref: Rewrite normalization and removed unused utils
* feat: Add maxValueLength option * meta: Add changelog
* feat: Remove esm rewrite script, expose module * feat: Add changelog
* feat: Add opentracing package * feat: Add traceId + references * ref: Rename flush * fix: Also add operation * feat: uuid4 split for spanId * feat: Add link:yarn script * feat: Update package.json * feat: Add event type * ref: Fix span json format * feat: Documenation * fix: Tests
Disable default fingerprinting
|
* Fork stack-trace * Remove stack-trace dependency * Oops, fix parser tests * Add attribution to tests and disable prefer-template for file
@HazAT with this change is there any recommended way to retrieve the breadcrumbs for given stack? Previously I was using: Sentry.getCurrentHub().stack[0].scope._breadcrumbs Now I changed it to: Sentry.getCurrentHub().getStack()[0].scope._breadcrumbs But I'm still accessing an internal property, and I would like to avoid that. (context, this is used on this middleware for redux: https://gist.github.com/olavoasantos/9ac791098758ee7dedf0c0424ec8b398#file-sentry-for-redux-js-L84) |
@JCMais we don't expose getters on the scope. However, your example can be simplified to: Sentry.getCurrentHub().getScope()._breadcrumbs;
|
While this major version bump and therefor "breaking", if people where using the exposed high level functions like:
nothing changes. There are some internal breaking changes if you directly worked with a
Client
, please see Changelog for more details.index.ts
maxValueLength
optionmodule
topackage.json
to support esm/esnextDedupe
optional?ref/make-sync
Use SyncPromise internally & Remove deprecated API & Trim Public API #1858