Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Correctly parse stack with braces in path #1948

Merged
merged 4 commits into from
Mar 20, 2019
Merged

Fix: Correctly parse stack with braces in path #1948

merged 4 commits into from
Mar 20, 2019

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Mar 20, 2019

This forks stack-trace to fix this issue because it looks like the project has become unmaintained.

image

The tests with all their profanity have also been ported over. 😆 Let me know if you want these editing!

Ref: getsentry/sentry-electron#154

@timfish timfish requested a review from kamilogorek as a code owner March 20, 2019 04:49
@HazAT HazAT merged commit 6755a66 into getsentry:major/5 Mar 20, 2019
HazAT pushed a commit that referenced this pull request Mar 20, 2019
* Fork stack-trace

* Remove stack-trace dependency

* Oops, fix parser tests

* Add attribution to tests and disable prefer-template for file
@timfish timfish deleted the fix/parsing-stack-with-braces branch March 20, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants