meta: Add Changelog entry for 8.7.0 #12280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses an alternative test method. Should reduce failures like [this](https://github.com/getsentry/sentry-javascript/actions/runs/9281632639/job/25538103763).
This adds a new E2E test `react-send-to-sentry` that is run optionally. For now this is the same as the old `standard-frontend-react` test - eventually we can/should update that test (and others) to stop sending to sentry. This test will run in a separate group that we do not block merging on when it fails. For now, there is one browser and one node test that checks that they send events successfully to Sentry - IMHO that should cover stuff decently for now. I also made the source maps debug ID test optional, as that inherently sends to Sentry. We can in follow ups get rid of all the event sending stuff from the remaining E2E tests. Part of #11910
No need for it anymore, and actually it is much simpler using fetch because that does not throw when encountering a 404 error!
Instead of just testing to send to Sentry, this now tests the actual payloads being sent. This kind of builds on top of #12259, where we specifically test the event sending now.
I noticed that locally the node-integration-tests that check versions fail, because in the SDK we use 18.18.0, we only check for "If node.major >= 18", and then get an incorrect test because actually in code we check the minor too. Instead of adjust this, IMHO it's better to update this. This also never failed on CI because there we do use latest 18 for the matrix tests...
This was not really needed, so we may as well remove it. We still use it in package scripts, which is fine I'd say. Note that this still does not "fix" the `yarn add` issue, but one step at a time...
Co-authored-by: Luca Forstner <[email protected]>
…extConfig.productionBrowserSourceMaps: true` is set (#12278)
lforst
approved these changes
May 29, 2024
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 8.6.0 release failed halfway through - this release should hopefully fix it.