Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): Remove axios from E2E tests #12275

Merged
merged 2 commits into from
May 29, 2024
Merged

test(e2e): Remove axios from E2E tests #12275

merged 2 commits into from
May 29, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented May 29, 2024

No need for it anymore, and actually it is much simpler using fetch because that does not throw when encountering a 404 error!

No need for it anymore, and actually it is much simpler using fetch because that does not throw when encountering a 404 error!
@mydea mydea requested review from lforst, Lms24 and andreiborza May 29, 2024 09:33
@mydea mydea self-assigned this May 29, 2024
Copy link
Contributor

github-actions bot commented May 29, 2024

size-limit report 📦

Path Size
@sentry/browser 21.73 KB (0%)
@sentry/browser (incl. Tracing) 32.76 KB (0%)
@sentry/browser (incl. Tracing, Replay) 68.2 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.63 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 72.25 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 84.32 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 86.13 KB (0%)
@sentry/browser (incl. metrics) 25.9 KB (0%)
@sentry/browser (incl. Feedback) 37.74 KB (0%)
@sentry/browser (incl. sendFeedback) 26.31 KB (0%)
@sentry/browser (incl. FeedbackAsync) 30.73 KB (0%)
@sentry/react 24.45 KB (0%)
@sentry/react (incl. Tracing) 35.78 KB (0%)
@sentry/vue 25.71 KB (0%)
@sentry/vue (incl. Tracing) 34.58 KB (0%)
@sentry/svelte 21.86 KB (0%)
CDN Bundle 23.06 KB (0%)
CDN Bundle (incl. Tracing) 34.48 KB (0%)
CDN Bundle (incl. Tracing, Replay) 68.31 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 73.31 KB (0%)
CDN Bundle - uncompressed 68 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 102.1 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 212 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 224.37 KB (0%)
@sentry/nextjs (client) 35.12 KB (0%)
@sentry/sveltekit (client) 33.37 KB (0%)
@sentry/node 114.66 KB (0%)
@sentry/aws-serverless 103.37 KB (0%)

Copy link
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@mydea mydea merged commit 91f6776 into develop May 29, 2024
74 checks passed
@mydea mydea deleted the fn/remove-axios branch May 29, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants