4 ➡️ 5 #622
Merged
4 ➡️ 5 #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
…ter. Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Feature to allow loading of a default set of system plugins from a file. This behavior will trigger when a world sdf file is loaded with no plugins defined. In this case, the simulator will load the plugins from a series of locations including environment variable, the users home folder, and finally in the installation directory. This should allow users to not have to specify the same set of plugins in every world sdf file. Signed-off-by: Michael Carroll <[email protected]> Co-authored-by: Louise Poubel <[email protected]>
* Added missing version namespace Signed-off-by: Nate Koenig <[email protected]> * Fix codecheck Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]>
Signed-off-by: Nick Lamprianidis <[email protected]>
Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: John Shepherd <[email protected]> Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Stephen Brawner <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]> Co-authored-by: Nate Koenig <[email protected]>
* change system injected playback path tag; update documentation * Remove <path> SDF param for LogPlayback Signed-off-by: Mabel Zhang <[email protected]> Co-authored-by: John Shepherd <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Michael Carroll <[email protected]>
* Added world exporter Signed-off-by: Gonzalo de Pedro <[email protected]> * Fixed CMake Signed-off-by: Gonzalo de Pedro <[email protected]> * Changes based on review Signed-off-by: Gonzalo de Pedro <[email protected]> * Added example world Signed-off-by: Nate Koenig <[email protected]> * bump required ign-common version Signed-off-by: Louise Poubel <[email protected]> * PR updates Signed-off-by: Nate Koenig <[email protected]> * Update documentation to have simulation self terminate Signed-off-by: Nate Koenig <[email protected]> * Rename world_export to collada_world_exporter Signed-off-by: Nate Koenig <[email protected]> * Finish world exporter renaming Signed-off-by: Nate Koenig <[email protected]> * Revert change Signed-off-by: Nate Koenig <[email protected]> * Added a tutorial Signed-off-by: Nate Koenig <[email protected]> * Update transform Signed-off-by: Nate Koenig <[email protected]> * Added message Signed-off-by: Nate Koenig <[email protected]> * Added a test Signed-off-by: Nate Koenig <[email protected]> * Added more shapes Signed-off-by: Nate Koenig <[email protected]> * Cleanup in two locations Signed-off-by: Nate Koenig <[email protected]> * Fix build Signed-off-by: Nate Koenig <[email protected]> * Apply scale, and fix codecheck Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Louise Poubel <[email protected]> Co-authored-by: Nate Koenig <[email protected]>
* Model creation tutorial using services Signed-off-by: ahcorde <[email protected]> * Updated tutorial Signed-off-by: ahcorde <[email protected]> * Tweaks to tutorial and example Signed-off-by: Louise Poubel <[email protected]> * Move files Signed-off-by: Louise Poubel <[email protected]> * example only needs ign-transport Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: Ashton Larkin <[email protected]>
Signed-off-by: Ashton Larkin <[email protected]>
…al time factor) (#536) Signed-off-by: Maganty Rushyendra <[email protected]> Signed-off-by: Luca Della Vedova <[email protected]> Co-authored-by: mrushyendra <[email protected]> Co-authored-by: Louise Poubel <[email protected]>
Move several server interactions and fuel cached to their own tests in integration. Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
chapulina
force-pushed
the
chapulina/4_to_5
branch
from
145897f to
b8dab13
Compare
chapulina
added a commit
that referenced
this pull request
Mar 1, 2021
Signed-off-by: Louise Poubel <[email protected]>
chapulina
added a commit
that referenced
this pull request
Mar 1, 2021
Signed-off-by: Louise Poubel <[email protected]>
chapulina
force-pushed
the
chapulina/4_to_5
branch
from
30b6be3 to
b0ff867
Compare
chapulina
added a commit
that referenced
this pull request
Mar 1, 2021
Signed-off-by: Louise Poubel <[email protected]>
chapulina
force-pushed
the
chapulina/4_to_5
branch
from
b0ff867 to
38cfde6
Compare
chapulina
added a commit
that referenced
this pull request
Mar 2, 2021
Signed-off-by: Louise Poubel <[email protected]>
chapulina
force-pushed
the
chapulina/4_to_5
branch
from
38cfde6 to
69ac140
Compare
chapulina
added a commit
that referenced
this pull request
Mar 2, 2021
Signed-off-by: Louise Poubel <[email protected]>
chapulina
force-pushed
the
chapulina/4_to_5
branch
from
69ac140 to
11c64f4
Compare
chapulina
added a commit
that referenced
this pull request
Mar 2, 2021
Signed-off-by: Louise Poubel <[email protected]>
chapulina
force-pushed
the
chapulina/4_to_5
branch
from
11c64f4 to
c0f7566
Compare
|
FYI, I know there are new changes in |
adlarkin
force-pushed
the
chapulina/4_to_5
branch
2 times, most recently
from
258a9d9 to
f8fef92
Compare
Signed-off-by: Louise Poubel <[email protected]>
adlarkin
force-pushed
the
chapulina/4_to_5
branch
from
f8fef92 to
dc60a3a
Compare
chapulina
added
needs upstream release
adlarkin
reviewed
Mar 3, 2021
There was a problem hiding this comment.
Although Windows CI compiles now, there are quite a bit of new warnings: https://build.osrfoundation.org/job/ign_gazebo-pr-win/2331/msbuild/new/
These warnings didn't seem to appear when we originally got Windows CI to compile: https://build.osrfoundation.org/job/ign_gazebo-pr-win/2330/
It looks like a lot of the warnings are related to protobuf, so I am not sure how much we can do about those. I'm also not sure why there were no warnings on build 2330, but a lot warnings on build 2331. Would it at least be worth addressing the other warnings (for example, optical tactile plugin and tape measure plugin)?
|
I'm looking into Windows warnings, you're right that we should be warning-free. |
|
Actually it looks like |
adlarkin
approved these changes
Mar 3, 2021
This was referenced Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port
ign-gazebo4tomainBranch comparison: main...ign-gazebo4
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)