-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated SDF examples #573
Updated SDF examples #573
Conversation
Signed-off-by: Jenn Nguyen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo3 #573 +/- ##
===============================================
+ Coverage 77.66% 77.71% +0.05%
===============================================
Files 208 208
Lines 11574 11574
===============================================
+ Hits 8989 8995 +6
+ Misses 2585 2579 -6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Even though DART is ignoring the size and creating an infinite plane, we should still specify it because it is required. Other physics engines may use it.
Isn't the size of the plane only meaningful for visualization? i.e, I thought all physics engines should create an infinite plane. If a plane is not infinite, why is it needed? You can just use a box shape. |
I think that's a fair question, but I'm not sure we can make this assumption. A box has 6 sides, while a plane can be interpreted to have 1 or 2 at most. So I can imagine a physics engine that implements a finite 2-sided plane without sides, for example. That could be something interesting to iterate on the SDF spec.
That's an interesting use case, because the collision visual may be misleading. Currently, even though the visual will be 100x100, the actual collision created by DART is infinite. |
Added
<size>
element to ground_plane collisions since it is a required spec of SDFormat in all example and test SDF files.This also provides collision visualization for the ground plane: #531