Add AboutDialogHandler #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: atharva-18 <[email protected]>
ahcorde
requested changes
Feb 3, 2021
There was a problem hiding this comment.
Please review the cpplint errors https://github.com/ignitionrobotics/ign-gazebo/pull/609/checks?check_run_id=1824526153
Signed-off-by: atharva-18 <[email protected]>
Signed-off-by: atharva-18 <[email protected]>
chapulina
added
close the gap
chapulina
reviewed
Feb 4, 2021
| "</td>" | ||
| "<td>" | ||
| "<a href='https://ignitionrobotics.org/libs/gazebo' " | ||
| "style='text-decoration: none; color: #f58113'>" |
There was a problem hiding this comment.
I don't know if there's a way, but it would be cool if these links used the Material.accent color. Don't worry if that's not straightforward, I think it's also ok to leave it as is.
Signed-off-by: atharva-18 <[email protected]>
Signed-off-by: atharva-18 <[email protected]>
Signed-off-by: atharva-18 <[email protected]>
chapulina
approved these changes
Feb 10, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference to #371
Summary:
GazeboDrawer.qmlListElementQML type'sactionattribute toactionElement.Screenshots:
