More world APIs, helper function ComponentData #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <[email protected]>
chapulina
added
the
migration
Codecov Report
@@ Coverage Diff @@
## ign-gazebo3 #378 +/- ##
===============================================
+ Coverage 77.21% 77.30% +0.09%
===============================================
Files 203 205 +2
Lines 10963 11018 +55
===============================================
+ Hits 8465 8518 +53
- Misses 2498 2500 +2
Continue to review full report at Codecov.
|
mjcarroll
reviewed
Oct 15, 2020
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
mjcarroll
approved these changes
Oct 16, 2020
mjcarroll
pushed a commit
that referenced
this pull request
Oct 21, 2020
Signed-off-by: Louise Poubel <[email protected]>
doisyg
pushed a commit
to wyca-robotics/ign-gazebo
that referenced
this pull request
Dec 13, 2020
Signed-off-by: Louise Poubel <[email protected]> Signed-off-by: Guillaume Doisy <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the added tutorial for the new APIs.
Also added the
EntityComponentManager::ComponentDatahelper function that returnsstd::nulloptif the entity doesn't have that component. It's a bit redundant that the user needs to pass 2 template arguments, but I couldn't find a better way.Part of solving #325