Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ionic: Video recorder tutorial fixes #2582

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Ionic: Video recorder tutorial fixes #2582

merged 1 commit into from
Sep 2, 2024

Conversation

caguero
Copy link
Contributor

@caguero caguero commented Sep 2, 2024

🦟 Bug fix

Minor fixes for the video recorder tutorial.

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@caguero
Video recorder tutorial fixes.
b588fdc 
Signed-off-by: Carlos Agüero <[email protected]>
@caguero caguero requested a review from mabelzhang as a code owner September 2, 2024 20:51
@caguero caguero mentioned this pull request Sep 2, 2024
Closed
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Sep 2, 2024
arjo129
arjo129 approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@arjo129 arjo129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arjo129 arjo129 merged commit 51819ae into gz-sim9 Sep 2, 2024
11 checks passed
@arjo129 arjo129 deleted the ionic_video_recorder_fix branch September 2, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjo129 arjo129 arjo129 approved these changes

@mabelzhang mabelzhang Awaiting requested review from mabelzhang mabelzhang is a code owner

Assignees
No one assigned
Labels
🏛️ ionic Gazebo Ionic
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caguero @arjo129