Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check AddBvhAnimation return value #1750

Merged
merged 3 commits into from
Nov 23, 2022
Merged

Check AddBvhAnimation return value #1750

merged 3 commits into from
Nov 23, 2022

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Oct 6, 2022

Signed-off-by: Nate Koenig [email protected]

🦟 Bug fix

Redo of #1632, targeting Fortress.

Summary

Check the return value of the AddBvhAnimation function call.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@nkoenig nkoenig requested a review from iche033 as a code owner October 6, 2022 17:15
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Oct 6, 2022
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #1750 (5d69ad3) into ign-gazebo6 (216d5a5) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@               Coverage Diff               @@
##           ign-gazebo6    #1750      +/-   ##
===============================================
- Coverage        64.60%   64.59%   -0.01%     
===============================================
  Files              321      321              
  Lines            26297    26300       +3     
===============================================
  Hits             16989    16989              
- Misses            9308     9311       +3     
Impacted Files Coverage Δ
src/rendering/SceneManager.cc 28.38% <0.00%> (-0.08%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@azeey azeey self-requested a review October 31, 2022 18:54
@azeey azeey removed their request for review November 11, 2022 05:21
@azeey azeey changed the title Check AddBvnAnimation return value Check AddBvhAnimation return value Nov 11, 2022
@nkoenig nkoenig merged commit 04618d7 into ign-gazebo6 Nov 23, 2022
@nkoenig nkoenig deleted the redo_1632 branch November 23, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants