3 ➡️ 4

[chapulina]

This ports #83, which changes the tests from ogre to ogre2. But I believe the LidarVisual test will need #116 to pass.

[iche033]

now that ogre2 tests are run with this PR, jenkins picked up a LidarVisual test failure, which may be fixed by pull request #116. cc @mihirk284

[chapulina]

I updated this PR now that #116 is merged, and INTEGRATION_lidar_visual is crashing. I can reproduce locally, it's a problem during destruction. here's a backtrace:

terminate called after throwing an instance of 'Ogre::InvalidParametersException'
  what():  OGRE EXCEPTION(2:InvalidParametersException): Vertex Buffer belongs to a Multisource pool, not this VaoManager in VaoManager::des
troyVertexBuffer at /var/lib/jenkins/workspace/ogre-2.1-debbuilder/repo/OgreMain/src/Vao/OgreVaoManager.cpp (line 127)

Thread 1 "INTEGRATION_lid" received signal SIGABRT, Aborted.
__GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
51      ../sysdeps/unix/sysv/linux/raise.c: No such file or directory.
(gdb) bt
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#1  0x00007ffff6778801 in __GI_abort () at abort.c:79
#2  0x00007ffff716b957 in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#3  0x00007ffff7171ae6 in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#4  0x00007ffff7170b49 in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#5  0x00007ffff71714b8 in __gxx_personality_v0 () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#6  0x00007ffff6b39573 in ?? () from /lib/x86_64-linux-gnu/libgcc_s.so.1
#7  0x00007ffff6b39df5 in _Unwind_Resume () from /lib/x86_64-linux-gnu/libgcc_s.so.1
#8  0x00007ffff0cc2a3d in Ogre::SubMesh::destroyVaos(Ogre::FastArray<Ogre::VertexArrayObject*>&, Ogre::VaoManager*, bool) ()
   from /usr/lib/x86_64-linux-gnu/libOgreMain.so.2.1.0
#9  0x00007ffff0cc2b66 in Ogre::SubMesh::~SubMesh() () from /usr/lib/x86_64-linux-gnu/libOgreMain.so.2.1.0
#10 0x00007ffff0b56b80 in Ogre::Mesh::unloadImpl() () from /usr/lib/x86_64-linux-gnu/libOgreMain.so.2.1.0
#11 0x00007ffff0bf6f37 in Ogre::Resource::unload() () from /usr/lib/x86_64-linux-gnu/libOgreMain.so.2.1.0
#12 0x00007ffff0b56ef7 in Ogre::Mesh::~Mesh() () from /usr/lib/x86_64-linux-gnu/libOgreMain.so.2.1.0
#13 0x00007ffff0b57019 in Ogre::Mesh::~Mesh() () from /usr/lib/x86_64-linux-gnu/libOgreMain.so.2.1.0
#14 0x00007ffff0a87a25 in ?? () from /usr/lib/x86_64-linux-gnu/libOgreMain.so.2.1.0
#15 0x00007ffff0c06059 in ?? () from /usr/lib/x86_64-linux-gnu/libOgreMain.so.2.1.0
#16 0x00007ffff0c0006d in Ogre::ResourceGroupManager::_notifyAllResourcesRemoved(Ogre::ResourceManager*) ()
   from /usr/lib/x86_64-linux-gnu/libOgreMain.so.2.1.0
#17 0x00007ffff0bfc8b5 in Ogre::ResourceGroupManager::shutdownAll() () from /usr/lib/x86_64-linux-gnu/libOgreMain.so.2.1.0
#18 0x00007ffff0c0fc13 in Ogre::Root::shutdown() () from /usr/lib/x86_64-linux-gnu/libOgreMain.so.2.1.0
#19 0x00007ffff0c110a0 in Ogre::Root::~Root() () from /usr/lib/x86_64-linux-gnu/libOgreMain.so.2.1.0
#20 0x00007ffff14d98fc in ignition::rendering::v4::Ogre2RenderEngine::Destroy (
    this=0x7ffff179df80 <ignition::common::SingletonT<ignition::rendering::v4::Ogre2RenderEngine>::GetInstance()::t>)
    at /home/chapulina/dome_ws/src/ign-rendering/ogre2/src/Ogre2RenderEngine.cc:119
#21 0x00007ffff7ba6762 in ignition::rendering::v4::RenderEngineManagerPrivate::UnloadEngine(std::_Rb_tree_iterator<std::pair<std::__cxx11::b
asic_string<char, std::char_traits<char>, std::allocator<char> > const, ignition::rendering::v4::RenderEngine*> >) ()
    at /home/chapulina/dome_ws/src/ign-rendering/src/RenderEngineManager.cc:334

[codecov]

Codecov Report

Merging #120 into master will increase coverage by 44.58%.
The diff coverage is 62.03%.

@@             Coverage Diff             @@
##           master     #120       +/-   ##
===========================================
+ Coverage    7.51%   52.09%   +44.58%     
===========================================
  Files          27      143      +116     
  Lines        1770    13070    +11300     
===========================================
+ Hits          133     6809     +6676     
- Misses       1637     6261     +4624     

Impacted Files	Coverage Δ
include/ignition/rendering/ParticleEmitter.hh	100.00% <ø> (ø)
include/ignition/rendering/Scene.hh	0.00% <ø> (ø)
include/ignition/rendering/base/BaseScene.hh	0.00% <ø> (ø)
ogre/src/OgreGrid.cc	0.00% <0.00%> (ø)
ogre/src/OgreLidarVisual.cc	0.00% <0.00%> (ø)
ogre2/src/Ogre2Camera.cc	87.70% <0.00%> (ø)
ogre2/src/Ogre2DepthCamera.cc	94.23% <ø> (ø)
src/RenderEngineManager.cc	76.21% <ø> (+50.81%)	⬆️
...ude/ignition/rendering/base/BaseParticleEmitter.hh	41.55% <40.00%> (ø)
ogre2/src/Ogre2Grid.cc	66.23% <45.00%> (ø)
... and 146 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 528ba21...87db562. Read the comment docs.

[iche033]

lasest ubuntu build is 🔵