Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6 ➡️ 7 #180

Merged
merged 6 commits into from
Sep 10, 2021
Merged

6 ➡️ 7 #180

merged 6 commits into from
Sep 10, 2021

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Sep 10, 2021 •
edited
Loading

➡️ Forward port

Port ign-msgs6 to ign-msgs7

Branch comparison: ign-msgs7...ign-msgs6

Needed by gazebosim/gz-sensors#154

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

j-rivero and others added 6 commits July 20, 2021 11:04
@j-rivero
Detect ign instead of using cmake module to check for ignition-tools (#…
e32a8bc 
…166)

Signed-off-by: Jose Luis Rivero <[email protected]>
@francocipollone
Adds PerformanceSensorMetrics proto message. (#172)
47dae0f 
* Adds PerformanceSensorMetrics proto message.

Signed-off-by: Franco Cipollone <[email protected]>

* Use Double for fps field.

Signed-off-by: Franco Cipollone <[email protected]>
@chapulina
5 ➡️ 6
d4af81f 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
5 ➡️ 6 (#174)
275afa7 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
🎈 6.6.0 (#176)
e559c9e 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
6 ➡️ 7
95ed95e 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina added the beta Targeting beta release of upcoming collection label Sep 10, 2021
@chapulina chapulina requested a review from caguero as a code owner September 10, 2021 01:28
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Sep 10, 2021
@chapulina chapulina mentioned this pull request Sep 10, 2021
Closed
@codecov
Copy link

codecov bot commented Sep 10, 2021 •
edited
Loading

Codecov Report

Merging #180 (2ce9f60) into ign-msgs7 (be01c59) will not change coverage.
The diff coverage is n/a.

❗ Current head 2ce9f60 differs from pull request most recent head 95ed95e. Consider uploading reports for the commit 95ed95e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           ign-msgs7     #180   +/-   ##
==========================================
  Coverage      84.78%   84.78%           
==========================================
  Files              7        7           
  Lines            828      828           
==========================================
  Hits             702      702           
  Misses           126      126

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be01c59...95ed95e. Read the comment docs.

@chapulina chapulina merged commit e746ae7 into ign-msgs7 Sep 10, 2021
@chapulina chapulina deleted the chapulina/6_to_7 branch September 10, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennuine jennuine jennuine approved these changes

@caguero caguero Awaiting requested review from caguero caguero is a code owner

Assignees
No one assigned
Labels
beta Targeting beta release of upcoming collection 🏢 edifice Ignition Edifice
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chapulina @jennuine @j-rivero @francocipollone