Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5 ➡️ 6 #174

Merged
merged 3 commits into from
Aug 9, 2021
Merged

5 ➡️ 6 #174

merged 3 commits into from
Aug 9, 2021

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-msgs5 to ign-msgs6.

ign-msgs6...ign-msgs5

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

j-rivero and others added 3 commits July 20, 2021 11:04
@j-rivero
Detect ign instead of using cmake module to check for ignition-tools (#…
e32a8bc 
…166)

Signed-off-by: Jose Luis Rivero <[email protected]>
@francocipollone
Adds PerformanceSensorMetrics proto message. (#172)
47dae0f 
* Adds PerformanceSensorMetrics proto message.

Signed-off-by: Franco Cipollone <[email protected]>

* Use Double for fps field.

Signed-off-by: Franco Cipollone <[email protected]>
@chapulina
5 ➡️ 6
d4af81f 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from caguero as a code owner August 6, 2021 23:06
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Aug 6, 2021
@codecov
Copy link

codecov bot commented Aug 6, 2021 •
edited
Loading

Codecov Report

Merging #174 (d4af81f) into ign-msgs6 (da912f3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-msgs6     #174   +/-   ##
==========================================
  Coverage      84.59%   84.59%           
==========================================
  Files              7        7           
  Lines            818      818           
==========================================
  Hits             692      692           
  Misses           126      126

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da912f3...d4af81f. Read the comment docs.

@chapulina chapulina merged commit 275afa7 into ign-msgs6 Aug 9, 2021
@chapulina chapulina deleted the chapulina/5_to_6 branch August 9, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caguero caguero caguero approved these changes

Assignees
No one assigned
Labels
🔮 dome Ignition Dome
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chapulina @caguero @j-rivero @francocipollone