Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect ign instead of using cmake module to check for ignition-tools #192

Merged
merged 4 commits into from
Aug 27, 2021
Merged

Detect ign instead of using cmake module to check for ignition-tools #192

merged 4 commits into from
Aug 27, 2021

Conversation

j-rivero
Copy link
Contributor

@j-rivero j-rivero requested a review from nkoenig as a code owner June 28, 2021 15:28
@chapulina
Copy link
Contributor

CI failure:

   + cd ../examples
  /entrypoint.sh: 9: cd: can't cd to ../examples

@scpeters
Copy link
Member

scpeters commented Aug 9, 2021

@osrf-jenkins run tests please

@scpeters
Copy link
Member

@j-rivero can you sign 091c317?

@j-rivero
Update CI to bionic
f348c5e 
Signed-off-by: Jose Luis Rivero <[email protected]>
@j-rivero j-rivero force-pushed the igntools_cmake_removal_1 branch from 091c317 to f348c5e Compare August 14, 2021 11:38
@j-rivero
Copy link
Contributor Author

@j-rivero can you sign 091c317?

ouch, sorry. Done.

@scpeters
Copy link
Member

there are some failing tests, but I believe they are already failing on the ign-fuel-tools1 branch:

@chapulina
Fix CI?
5163040 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
fix server
7ee0675 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Copy link
Contributor

I fixed some tests in 5163040 and 7ee0675, and relaxed the merge requirements for branches 0~3 so that PRs are not blocked until someone has time to fix CI completely.

@chapulina chapulina merged commit 1fd61c6 into ign-fuel-tools1 Aug 27, 2021
@chapulina chapulina deleted the igntools_cmake_removal_1 branch August 27, 2021 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters approved these changes

@nkoenig nkoenig Awaiting requested review from nkoenig nkoenig is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j-rivero @chapulina @scpeters