Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tracker] Remove ignition-tools cmake check in Ignition software #472

Open
6 of 12 tasks
j-rivero opened this issue Jun 21, 2021 · 0 comments
Open
6 of 12 tasks

[tracker] Remove ignition-tools cmake check in Ignition software #472

j-rivero opened this issue Jun 21, 2021 · 0 comments
Assignees

Comments

@j-rivero
Copy link
Contributor

j-rivero commented Jun 21, 2021

Currently the ignition-tools code generates a CMake/pkg-config module installed in the system with minimal information (package is pure ruby), the rest of the Ignition family is detecting at building time if ignition-tools is present on the system and installing the corresponding submodule for ign tool. This can be suboptimal:

  • build time to decide if an user wants or not the ign submodule is not the best moment.
  • ign modules are cheap in every sense (small ruby files)

Let's remove the check and install ign submodules files unconditionally:

  • fuel 1
  • fuel 5 : forward --> 6, main
  • gui 3 : forward --> 4, 5, main
  • msgs 1
  • msgs 5 : forward --> 6, 7, main
  • sdformat 6
  • sdformat 9
  • sdformat 12, main
  • transport 4
  • transport 8 : forward --> 9, 10, main
  • gazebo / sim 3
  • launch 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant