Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Conda Windows warnings #652

Merged
merged 5 commits into from
Dec 8, 2024
Merged

Conversation

j-rivero
Copy link
Contributor

A missing header and a couple of tweaks to make the MSVC compiler happy.

Complaining: https://build.osrfoundation.org/view/conda/job/gz_common-5-cwin/1/msbuild/

Fixed: https://build.osrfoundation.org/job/_test_gz_common-pr-cwin/8/

j-rivero and others added 4 commits October 16, 2024 14:34
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
@j-rivero j-rivero requested a review from marcoag as a code owner November 28, 2024 13:48
@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels Nov 28, 2024
@j-rivero j-rivero merged commit a4feedc into gz-common5 Dec 8, 2024
11 checks passed
@j-rivero j-rivero deleted the jrivero/fix_conda_warnings branch December 8, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants