Skip to content

Commit

Permalink
Remove Conda Windows warnings (#652)
Browse files Browse the repository at this point in the history
* Missing include
* Fix warnings in Conda Windows

---------
Signed-off-by: Jose Luis Rivero <[email protected]>
  • Loading branch information
j-rivero authored Dec 8, 2024
1 parent 12aec5b commit a4feedc
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions graphics/src/AssimpLoader.cc
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
#include <assimp/Importer.hpp> // C++ importer interface
#include <assimp/postprocess.h> // Post processing flags
#include <assimp/scene.h> // Output data structure
#include <assimp/material.h>

// Disable warning for converting double to unsigned char
#ifdef _WIN32
Expand Down
4 changes: 2 additions & 2 deletions graphics/src/AssimpLoader_TEST.cc
Original file line number Diff line number Diff line change
Expand Up @@ -684,7 +684,7 @@ TEST_F(AssimpLoader, LoadGlTF2BoxTransmission)
const common::MaterialPtr mat = mesh->MaterialByIndex(0u);
ASSERT_TRUE(mat.get());
// transmission currently modeled as transparency
EXPECT_FLOAT_EQ(0.1, mat->Transparency());
EXPECT_FLOAT_EQ(0.1f, mat->Transparency());
delete mesh;
#endif
}
Expand Down Expand Up @@ -791,7 +791,7 @@ TEST_F(AssimpLoader, LoadGlbPbrAsset)
EXPECT_NE(pbr->RoughnessMapData(), nullptr);
// Check pixel values to test metallicroughness texture splitting
EXPECT_FLOAT_EQ(pbr->MetalnessMapData()->Pixel(256, 256).R(), 0.0);
EXPECT_FLOAT_EQ(pbr->RoughnessMapData()->Pixel(256, 256).R(), 124.0 / 255.0);
EXPECT_FLOAT_EQ(pbr->RoughnessMapData()->Pixel(256, 256).R(), 124.0f / 255.0f);

// Bug in assimp 5.0.x that doesn't parse coordinate sets properly
// \todo(iche033) Lightmaps are disabled for glb meshes
Expand Down

0 comments on commit a4feedc

Please sign in to comment.