Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upgrade] Move the etcd from v3.4.26 to v3.4.34 to v3.5.x #445

Open
3 of 6 tasks
ishan16696 opened this issue Oct 6, 2022 · 7 comments
Open
3 of 6 tasks

[Upgrade] Move the etcd from v3.4.26 to v3.4.34 to v3.5.x #445

ishan16696 opened this issue Oct 6, 2022 · 7 comments
Assignees
Labels
kind/enhancement Enhancement, improvement, extension priority/2 Priority (lower number equals higher priority)
Milestone

Comments

@ishan16696
Copy link
Member

ishan16696 commented Oct 6, 2022

Feature (What you would like to be added):
Upgrade the etcd from v3.4.26 to v3.5.x.

Motivation (Why is this needed?):
We are missing many fixes which comes only in latest version of etcd 3.5.x. eg:

  1. [Second Solution] Fix the potential data loss for clusters with only one member (simpler solution) etcd-io/etcd#14400
  2. etcdserver: export method EtcdServer.leaderChangedNotify (#12378) etcd-io/etcd#12410
  3. Enhance health check endpoint to support serializable request etcd-io/etcd#13399
    and many more

The upgrade will be completed stepwise:

Approach/Hint to the implement solution (optional):
We haven't decided to which exact version we want to move. We have to find the stable version of etcd v3.5.x which is good for production use with very less or none severe issues reported on upstream.

@ishan16696
Copy link
Member Author

/assign

@abdasgupta
Copy link
Contributor

Any progress to this? Did we find which ETCD version to use?

@ishan16696
Copy link
Member Author

no update from my side as I'm busy with refactoring. Anybody can this over.
/unassign

@ishan16696 ishan16696 self-assigned this Dec 12, 2022
@abdasgupta abdasgupta added the priority/4 Priority (lower number equals higher priority) label Jan 5, 2023
@ishan16696
Copy link
Member Author

ishan16696 commented Jan 12, 2023

This issue of moving the custom-etcd image: gardener/etcd-custom-image#16 to golang app requires latest etcd v3.5.x, Hence this is dependent on etcd version upgrade to take advantage of various functionality like EtcdServer.leaderChangedNotify. IMO, we have to increase the priority of this issue.

@shreyas-s-rao
Copy link
Contributor

In an out-of-band discussion with @ishan16696 @unmarshall @ashwani2k @abdasgupta , we decided that this change cannot be clubbed with the release of etcd-steward (as previously thought of). This change requires a dedicated release of etcdbr+druid, so that the change is deterministic, and no other changes are clubbed with it.

@ishan16696 ishan16696 modified the milestones: 2023-Q2, 2024-Q1 Jan 23, 2024
@seshachalam-yv seshachalam-yv changed the title [Upgrade] Move the etcd from v3.4.13 to v3.5.x [Upgrade] Move the etcd from v3.4.26 to v3.5.x Mar 27, 2024
@renormalize renormalize changed the title [Upgrade] Move the etcd from v3.4.26 to v3.5.x [Upgrade] Move the etcd from v3.4.26 to v3.4.32 to v3.5.x Jun 27, 2024
@ialidzhikov
Copy link
Member

This is also important for Kubernetes 1.31: see gardener/etcd-wrapper#28

@renormalize renormalize changed the title [Upgrade] Move the etcd from v3.4.26 to v3.4.32 to v3.5.x [Upgrade] Move the etcd from v3.4.26 to v3.4.34 to v3.5.x Oct 10, 2024
@renormalize
Copy link
Member

renormalize commented Oct 10, 2024

We've decided to move to the latest patch, v3.4.34. I've started work on this.
Work will be tracked here gardener/etcd-backup-restore#792.

@renormalize renormalize self-assigned this Oct 10, 2024
@renormalize renormalize removed the lifecycle/stale Nobody worked on this for 6 months (will further age) label Nov 8, 2024
@renormalize renormalize modified the milestones: 2024-Q1, 2025-Q1 Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension priority/2 Priority (lower number equals higher priority)
Projects
None yet
Development

No branches or pull requests

8 participants