Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListTasks: proposed filters #104

Closed
wants to merge 3 commits into from

Conversation

adamstruck
Copy link
Member

Filter on tags and/or state.

Funnel has been using these filters since February and it seems to be sufficient for our use cases.

@delagoya
Copy link
Collaborator

@adamstruck Is this still a request for schema enhancement? Given the move to OAS, would you like to propose this as a new PR on the swagger schema?

@adamstruck
Copy link
Member Author

Once #111 and #113 are in I will update this PR to be against the swagger definitions.

@susheel
Copy link
Member

susheel commented Mar 6, 2019

@adamstruck Could you update this PR to the new YAML spec in develop

@adamstruck adamstruck changed the base branch from master to develop March 7, 2019 20:45
@adamstruck
Copy link
Member Author

I updated the PR.

Unfortunately, the proposed tags filter can't be expressed as a query parameter in openAPI 2.0.

@kellrott
Copy link
Member

kellrott commented Mar 7, 2019

So theoretically we could get the tags field as a json map in openAPI 3.0? But we're not sure if the rest of the GA4GH group wants to move there yet?

@vsmalladi
Copy link
Contributor

@kellrott has this been addressed by #170 and can we close this?

@adamstruck adamstruck closed this Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants