-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate analyzers via msbuild #2968
Merged
nojaf
merged 17 commits into
fsprojects:main
from
dawedawe:integrate_analyzers_via_msbuild
Oct 26, 2023
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
604fe39
integrate analyzers via msbuild magic
dawedawe d4c6c1d
try wildcard for sarif upload, might need to change to directory
dawedawe cc96aa3
try another wildcard for sarif files
dawedawe c2bfc80
collect sarif files in dedicated directory to be able to upload them …
dawedawe c05a1b7
add back env vars
dawedawe 1306220
remove stale open statement
dawedawe 652399e
update analyzers tool and gr analyzers package
dawedawe ec15822
move setting of env vars
dawedawe c28354c
delete "Directory.Solution.props"
dawedawe d16986b
remove message
dawedawe 94c7b20
needs some UsingTask magic I don't know currently
dawedawe 0aca8c6
fix build for now
dawedawe 6d1607d
cool kids project cracking
dawedawe 4eafd91
restore all fail-on-warnings
dawedawe 1ea1bcd
use analysisreports dir
dawedawe 52803eb
use $(SolutionFileName) instead of hard coding name
dawedawe 6fc449f
Set environment variables in target.
nojaf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would put this closer to the tool invocation.
Can we do this right before the
<Exec Command
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably using https://learn.microsoft.com/en-us/visualstudio/msbuild/setenv-task?view=vs-2022