-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate analyzers via msbuild #2968
Integrate analyzers via msbuild #2968
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good start!
build.fsx
Outdated
@@ -82,6 +82,9 @@ pipeline "Build" { | |||
stage "Build" { run "dotnet build -c Release" } | |||
stage "Analyze" { | |||
run (fun _ -> async { System.IO.Directory.CreateDirectory(analysisReportsDir) |> ignore }) | |||
envVars |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would put this closer to the tool invocation.
Can we do this right before the <Exec Command
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two nits left but man this is good stuff! Can you check the envVars
thing as well please.
|
@dawedawe The reason I want to set |
The sarif file upload might not work yet. Let's try with a wildcard first and then go to a directory to collect all sarif files and upload that.