Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sizing of code elements inside headers. #905

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Fix sizing of code elements inside headers. #905

merged 2 commits into from
Mar 5, 2024

Conversation

teo-tsirpanis
Copy link
Contributor

Fixes formatting when code elements are used inside elements that have a different font size like headers.

@nojaf
Copy link
Collaborator

nojaf commented Mar 3, 2024

Hi, this was done rather deliberately for Safari.
Can you please submit a before and after screenshot of this change?
I'd like to know more about the context here.

@teo-tsirpanis
Copy link
Contributor Author

Before:
image

After:
image

@nojaf
Copy link
Collaborator

nojaf commented Mar 4, 2024

Thanks, I would prefer to go with:

h1 code, h2 code, h3 code, h4 code, h5 code, h6 code {
    font-size: inherit;
}

instead as the font-size is now set deliberately to fix #889.

@teo-tsirpanis
Copy link
Contributor Author

Feedback addressed @nojaf.

@teo-tsirpanis teo-tsirpanis changed the title Do not set font size on code elements. Fix sizing of code elements inside headers. Mar 5, 2024
Copy link
Collaborator

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Would you like to have a new release with this fix?

@teo-tsirpanis
Copy link
Contributor Author

I can wait for a few weeks, there's no immediate need to make a release just for this.

@nojaf nojaf merged commit 0a310f2 into fsprojects:main Mar 5, 2024
3 checks passed
@nojaf
Copy link
Collaborator

nojaf commented Mar 5, 2024

Alright thanks!

@teo-tsirpanis teo-tsirpanis deleted the patch-1 branch March 5, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants