Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output font size on mobile safari is too big #889

Closed
nhirschey opened this issue Dec 1, 2023 · 6 comments
Closed

Output font size on mobile safari is too big #889

nhirschey opened this issue Dec 1, 2023 · 6 comments

Comments

@nhirschey
Copy link
Collaborator

Maybe my phone is weird, but I’m not seeing raw fsi output scaling correctly in docs. See screenshot from the csv provider below. The green “HLOC” output text font size is too big compared to the body text and fsharp code block.

I cannot reproduce this with small window sizes desktop edge browser, but I consistently get it with my iPhone.

image

@nojaf
Copy link
Collaborator

nojaf commented Dec 1, 2023

Hi @nhirschey, thanks for the report.
Could you give me the exact link to this page?
I'll take a look.

@nhirschey
Copy link
Collaborator Author

nhirschey commented Dec 1, 2023

Thanks @nojaf
https://fsprojects.github.io/FSharp.Data/library/CsvProvider.html

It seems to happen when the output is bigger than the window. Also see my teaching site here. Simple tuple output like ‘ val it: int * int = (1, 2)’ is formatted correctly but if you scroll down fsi output for ‘simpleReturnTuple’ is too big.

image

@nhirschey
Copy link
Collaborator Author

Another example in compiler docs release notes, the snippet font size on this page is all too big

https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html

@nojaf
Copy link
Collaborator

nojaf commented Dec 20, 2023

Thanks, the problem here is that I need to see this in Safari to be able to address it.
I should try and have a screen sharing session with someone that has a Mac. I can't reproduce this in the Chrome emulator, so I believe the problem is a browser styling default that we still need to override.

@nojaf
Copy link
Collaborator

nojaf commented Jan 9, 2024

Hi @nhirschey, could you try https://www.nuget.org/packages/FSharp.Formatting/20.0.0-alpha-017 on your personal website? It might improve things.

@nhirschey
Copy link
Collaborator Author

nhirschey commented Jan 10, 2024

Hi @nojaf, thanks for giving this a shot. I upgraded to alpha 17 but the problem is still there unfortunately.

Ex the “ val x: RecordExample …” output at https://nhirschey.github.io/Teaching/fundamentals.html#Records

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants