Test projects

[nhirschey]

Fixes #800. Mostly relies on projInfos now to exclude test projects, but for building FSharp.Formatting docs correctly we need custom code to exclude this library's own test projects from the ApiDocs.

I exclude FSharp.Formatting test projects using

if s.Contains("tests\\FSharp") then

We could be more explicit, such as below, but then if a future person adds additional test projects to this library they might forget to explicitly exclude them

if s.Contains("FSharp.ApiDocs.Tests") || s.Contains("FSharp.Formatting.TestHelpers")

[nojaf]

Are you sure about this bit?
When I commented out the |> List.choose I was able to run all the tests just fine.

(I ran dotnet run --project .\build\build.fsproj -- -t Tests at the root)

[nhirschey]

The tests run fine, the problem is that FSharp.Formatting tests run on regular (non-test) projects such as this one: https://github.com/fsprojects/FSharp.Formatting/blob/main/tests/FSharp.ApiDocs.Tests/files/crefLib1/crefLib1.fsproj

crefLib1 itself is not a test project, so if we do not exclude it explicitly somehow then crefLib1 will be added to FSharp.Formatting's api reference here: https://fsprojects.github.io/FSharp.Formatting/reference/index.html

[nhirschey]

Here's what it looks like if I delete the |> List.choose lines, build the library and then run

src\fsdocs-tool\bin\Debug\net7.0\fsdocs.exe watch`

Note the extra libraries added to docs. I'm not sure what the best way to exclude them was ... I know what I did is a hack, slightly more strict than what was there before but still more general than we'd probably like.

[nojaf]

Ah ok, I see. Thanks for clarifying that.
In that case, I would go for a slightly more strict approach like:

            let fsharpFormattingTestProjectMarker = $"FSharp.ApiDocs.Tests{Path.DirectorySeparatorChar}files"

            projectFiles
            |> List.filter (fun s ->
                let isTestProject = s.Contains fsharpFormattingTestProjectMarker

                if isTestProject then
                    printfn
                        $"  skipping project '%s{Path.GetFileName s}' because it is a project part of the FSharp.Formatting test suite."

                not isTestProject)

To really put emphasis on those selected projects that we are excluding.
The Path.DirectorySeparatorChar would make it work cross-platform, I'm not sure the current solution would.

What do you think?

[nhirschey]

Sure, I just pushed a more strict version based on your suggestion plus the required filtering out of tests/FSharp.Formatting.TestHelpers/FSharp.Formatting.TestHelpers.fsproj. The test helpers project will otherwise show up in FSharp.Formatting API docs (same reason as discussed earlier in thread).

[nojaf]

Sorry, I forgot about this 🙈.
Thank you for this PR!