-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better "Tests" detection #800
Comments
Hi there, thanks for bringing this up. |
Another option is don't filter out test projects if they're specified by the I believe we'd get that functionality if we moved the "test" project filtering so that it only applies inside match case on line 392.
|
Good suggestion! |
I'm guessing this code is trying to avoid cracking as we could look post crack at either |
Honestly, just lean into cracking :) If you use something like buildalyzer to 'drive' the build out of proc it should be relatively stable across MSBuild versions, and this property only relies on evaluation not execution so changes in target ordering across SDK versions shouldn't impact you. From a performance perspective, you can toggle MSBuild Server on (or wait for it to be toggled on by default) and a lot of the process-spawning overhead should just disappear. |
This code might actually pre-date |
|
That sounds good to me. How would one achieve this easily? Loading the |
You shouldn't need to run any targets - the act of loading the project file is evaluation, and after evaluation you have access to all properties that are statically-known (including those delivered by SDKs). Evaluation is generally quite fast, it's running design-time-builds (like editors need to to get compiler options) that takes some time. |
I think we just delete lines 426-433.
We'd need to test but scanning the code, just delete 426-433. |
👋 I was trying out fsdocs in repository. When trying to generate docs for reference information I kept getting:
Turns out it's because I'm in a directory that has the word "test" in it. "fsdocstester/src/Project1".
FSharp.Formatting/src/fsdocs-tool/ProjectCracker.fs
Line 429 in e665aa9
I know it's an unlikely case but I'm always the one to hit those 😂 .
The text was updated successfully, but these errors were encountered: