Refactor the project cracker into a new file et al. #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not report nonexistent substitution parameters (see changes in the param function of ProjectCracker.fs).
Seq.pairwise [1;2;3;4] returns [1,2; 2,3; 3,4], not [1,2; 3,4].
And use Process.Start with UseShellExecute on all platforms (it is implemented on .NET Core).
Remove duplicate code in a helper function in BuildCommand.fs.
The most important is the replacement of the tree-based FSharpMap with the hashtable-based readOnlyDict.
…e thrown. It is not needed. They will already be reported to the console and AggregateExceptions are not correctly handled.
| if this.strict then exit 1 | ||
| false | ||
| with ex -> | ||
| Log.errorf "received exception :\n %A" ex |
There was a problem hiding this comment.
Doesn't seem to be any different logic related to aggregate exceptions 👍
dsyme
approved these changes
Oct 24, 2020
dsyme
reviewed
Oct 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
BuildCommand.fsby moving the project cracker in a file calledProjectCracker.fs.--parametersoption and document how to use that command.fsdocs-repository-link --> {{fsdocs-repository-link}}).System.Text.Jsonin the documentation search index serializer.paket.lock.