-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry project cracking when there isn't a targetPath #613
Retry project cracking when there isn't a targetPath #613
Conversation
Fix conflicts with master please? |
Will do. |
How does it look now @dsyme ? |
big conflict here, with #618 , my apologies |
I should have prioritised this one since you've already fixed conflicts one :-( |
Does it look OK @teo-tsirpanis ? |
Yes @wallymathieu, it seems OK to me. BTW most of it will be rewritten anyway when ionide/proj-info#87 is fixed. |
Sounds good. So then some of this can be removed once that happens 🙂? |
Yep. But let's merge it for now... |
The conflict was kind of small in the sense that it was mostly moved code. |
I'll merge it @dsyme later on today. |
I've based the logic on this comment:
https://github.com/alfonsogarciacaro/TypeProviderTest/blob/4cb6442afce6db707e56a1a43c79d3cc7cd4211a/ASTViewer/ProjectCoreCracker.fs#L111-L114