-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds methods for cross-type links #330
Conversation
Adds basic test for linking types. Adds methods to collect all indirect links, find the type references and add the links to the found types.
This is looking great! I like the trick where you're finding all links and add the definitions for them, that's clever :-). I wonder what would be the most common uses for this. I had a quick look at some of the Deedle docs and that is mostly using the backtick (inline code) when referring to other functions/types/modules. So obviously, getting it to work for Deedle would be one nice thing. I'm not sure what other features would make the most sense. I'll ask for feedback on Twitter :) |
* master: Release 2.10.0 Fix bug in CSharpFormat paket update && change logging setup logic to include Yaaf.FSharp.Scripting. fix path of documentation file. Switch to a logging Framework (System.Diagnostics.TraceSource) for better configuration.
Added more test cases for - Types with duplicated names - Inexistent types Restricted links to be only internal because if the type is not found in `UrlMap.ResolveCref`, the url returned is a URL to msdn documentation.
I haven't saw any feedback, so I continued with my implementation. 😄 I have added the possibility to link using only the type simple name instead of the full type name. I am not sure if links to external types should be supported. I believe they should not. With this, I am near to be able to create links when backtick is used. I will restrict myself to types and modules in this pull request and I will try to add links to functions later. |
* master: Specify range for FCS in NuGet (sort of fix #337) Fix broken script Update release notes Wrap logging setup in try catch paket update && fix compilation.
Looks good to me. Just one note: If you cannot resolve the name due to duplicate possibilities it might make sense to notify the user with a logging entry (warning?).
In Again very nice! I think I will update the Thinking about this further: Maybe it would make sense in the future to generate the reference documentation before the |
* master: release notes. paket update bump to 2.11.0-alpha2. FullName can fail. Add Gitter badge General stabilization. Ignore when we cannot handle a module, type or a single member and write an error, workaround for #271 (and future FCS bugs). add overload that takes a sequence, fixes #49 create and push tag disable ReleaseBinaries (to not push an alpha there). Do we still need this? Change Url to be able to push without password. Update to 2.11.0-alpha1 Update Yaaf.FSharp.Scripting (now uses the 4.5 reference assemblies). Fixes crash with C# extension methods when the assembly containing them was build against net45. Fixes #201. (Might fix) References #328, #325, #139 Make [omit] work when markDownComments is false. Fail early when we cannot get the attributes of the current member.
Finally had time to continue working on this. Basically I just finished the implementation. |
Good to go!... I hope. 😄 |
[WIP] Adds methods for cross-type links
As discussed in Issue #52
This pull request allows to create links to other types in the assembly using markdown style links with the name of a type. It can be full name or simple name:
Work in progress. Please review.
TODO: