Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unresolved reference to log -> Print source (type/member) of the error. #366

Closed
haf opened this issue Dec 19, 2015 · 5 comments
Closed

Unresolved reference to log -> Print source (type/member) of the error. #366

haf opened this issue Dec 19, 2015 · 5 comments

Comments

@haf
Copy link
Member

haf commented Dec 19, 2015

I'm getting this message:

FSharp.Formatting Warning: 0 : Unresolved reference 'log'!

What does it mean? Where is it and what's it trying to find?

@matthid
Copy link
Member

matthid commented Dec 19, 2015

We have some code in place to resolve type member names in the documentation, for example if you write <c ref='T:Some.Type' />' we can resolve this to a proper link to the correct documentation for that type/member/module or whatever.

Recently (#330) we can do that for markdown as well via [Some.Type].

The error means, that you somewhere have a reference we could not resolve (for example in this case [log] or <c ref='log' />). You can try again with the fully qualified name - in case of <c ref - or ignore the error because currently we only support type-names - in case of [log]/markdown. Or you can of course contribute the code such that we support members and let bindings ;)

@haf
Copy link
Member Author

haf commented Dec 19, 2015

Can you make it print where the warning comes from?

@matthid
Copy link
Member

matthid commented Dec 19, 2015

I think you can search for UNRESOLVED( as a workaround for now in the generated html pages. Is that OK for now?

But I definitly like the suggestion. The change is probably more invasive as one might suggest, but I would accept a PR for it.

@matthid
Copy link
Member

matthid commented Dec 19, 2015

The signature of https://github.com/tpetricek/FSharp.Formatting/blob/master/src/FSharp.MetadataFormat/Main.fs#L162 needs to be changed to return the reason/error and the error must be logged at the call side.

@matthid matthid changed the title [question] Unresolved reference to log? Unresolved reference to log -> Print source (type/member) of the error. Dec 19, 2015
@matthid
Copy link
Member

matthid commented Jan 14, 2016

Tracked in #370

@matthid matthid closed this as completed Jan 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants