Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-added internal class generated for AssemblyInfo.vb #827

Merged
merged 1 commit into from
Jun 10, 2015
Merged

Re-added internal class generated for AssemblyInfo.vb #827

merged 1 commit into from
Jun 10, 2015

Conversation

allykzam
Copy link
Contributor

@allykzam allykzam commented Jun 9, 2015

Was removed in 63185e7 for #673 due to errors building. Contrary to the prior report, classes can be added to AssemblyInfo.vb.

Two issues resolved here are:

  1. In a VB.NET project named TestApp, using Namespace System in user-code results in a namespace named TestApp.System being created, which causes the System namespace to be hidden. Removed the namespace declaration around the class to resolve this.
  2. As pointed out in Remvoved internal class generated in AssemblyInfo.Vb #673, the class definition had no name. Added the name used in the C#/F# code.

Was removed in 63185e7 for #673 due to
errors building. The existing code did not work because of the attempt
to put it in the System namespace, and the lack of a class name.
@forki
Copy link
Member

forki commented Jun 9, 2015

@Vidarls could you please review? Thx to you both

@Vidarls
Copy link

Vidarls commented Jun 10, 2015

Looks good to me :)

forki added a commit that referenced this pull request Jun 10, 2015
Re-added internal class generated for AssemblyInfo.vb
@forki forki merged commit 3ce3263 into fsprojects:master Jun 10, 2015
@forki
Copy link
Member

forki commented Jun 10, 2015

cool thx

@forki
Copy link
Member

forki commented Jun 10, 2015

released in 3.35

@allykzam
Copy link
Contributor Author

Thanks, @forki :)

@allykzam allykzam deleted the fix-assemblyinfo-vb branch June 10, 2015 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants