Remvoved internal class generated in AssemblyInfo.Vb #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems adding classes to AssemblyInfo.vb may not be supported.
|
I think @simonhdickson, @pblasucci, @tpetricek and @petersondrew worked on this file. |
forki
added a commit
that referenced
this pull request
Mar 4, 2015
Remvoved internal class generated in AssemblyInfo.Vb
|
None here 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on adding vb.net support in ProjectScaffold, and trying to run the assemblyinfo generate task caused build of vb.net project to fail.
Removing the generated class fixed the problem.
(I know the generated class actually had a syntax error, missing the class name, but even fixing this failed the build.)
It seems adding classes to AssemblyInfo.vb may not be supported, though I could not find any info on it.
Suggesting to remove the generated class from AssemblyInfo.vb for now, until more info is found.
(Also I might look into this part of the build process as part of figuring out what to do with fsprojects/ProjectScaffold#107 )