-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove requirements files #1511
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario
requested review from
wild-endeavor,
kumare3,
pingsutw and
cosmicBboy
as code owners
February 17, 2023 03:57
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1511 +/- ##
==========================================
+ Coverage 69.31% 69.34% +0.02%
==========================================
Files 305 305
Lines 28657 28642 -15
Branches 2714 2310 -404
==========================================
- Hits 19864 19861 -3
+ Misses 8276 8266 -10
+ Partials 517 515 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This reverts commit 50cbb4d. Signed-off-by: Eduardo Apolinario <[email protected]>
This reverts commit eae945c. Signed-off-by: Eduardo Apolinario <[email protected]>
pingsutw
approved these changes
Feb 17, 2023
10 tasks
eapolinario
added a commit
that referenced
this pull request
Feb 28, 2023
* Remove mentions to spark Signed-off-by: Eduardo Apolinario <[email protected]> * Remove mentions to requirements.txt and dev-requirements.txt Signed-off-by: Eduardo Apolinario <[email protected]> * Remove plugins requirements. Signed-off-by: Eduardo Apolinario <[email protected]> * Remove all_requirements target from plugins makefile Signed-off-by: Eduardo Apolinario <[email protected]> * Use dev-requirements.in in lint gh action job Signed-off-by: Eduardo Apolinario <[email protected]> * Revert "Remove all_requirements target from plugins makefile" This reverts commit 50cbb4d. Signed-off-by: Eduardo Apolinario <[email protected]> * Revert "Remove plugins requirements." This reverts commit eae945c. Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario
added a commit
that referenced
this pull request
Feb 28, 2023
* Remove mentions to spark Signed-off-by: Eduardo Apolinario <[email protected]> * Remove mentions to requirements.txt and dev-requirements.txt Signed-off-by: Eduardo Apolinario <[email protected]> * Remove plugins requirements. Signed-off-by: Eduardo Apolinario <[email protected]> * Remove all_requirements target from plugins makefile Signed-off-by: Eduardo Apolinario <[email protected]> * Use dev-requirements.in in lint gh action job Signed-off-by: Eduardo Apolinario <[email protected]> * Revert "Remove all_requirements target from plugins makefile" This reverts commit 50cbb4d. Signed-off-by: Eduardo Apolinario <[email protected]> * Revert "Remove plugins requirements." This reverts commit eae945c. Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario
added a commit
that referenced
this pull request
Feb 28, 2023
…pgrade (#1458) (#1525) * Flytekit Auth system overhaul and pretty printing upgrade (#1458) * [wip] New authentication system - Reuse local keyring better - use grpc based auth system Signed-off-by: Ketan Umare <[email protected]> * Better error handling and printing, better exception handling and retrying Signed-off-by: Ketan Umare <[email protected]> * Delete legacy files Signed-off-by: Ketan Umare <[email protected]> * add missing None Signed-off-by: Ketan Umare <[email protected]> * keyring removed Signed-off-by: Ketan Umare <[email protected]> * added insecure_skip_verify Signed-off-by: Ketan Umare <[email protected]> * test fixed Signed-off-by: Ketan Umare <[email protected]> * Test fixed Signed-off-by: Ketan Umare <[email protected]> * Auth update Signed-off-by: Ketan Umare <[email protected]> * updated test Signed-off-by: Ketan Umare <[email protected]> * updated Signed-off-by: Ketan Umare <[email protected]> * flush buffer instead of closing, was getting a weird stack trace. make the image smaller Signed-off-by: Yee Hing Tong <[email protected]> * updated ca-cert logic Signed-off-by: Ketan Umare <[email protected]> * Fixed unit tests Signed-off-by: Ketan Umare <[email protected]> * updated Signed-off-by: Ketan Umare <[email protected]> * test fix Signed-off-by: Ketan Umare <[email protected]> * updated Signed-off-by: Ketan Umare <[email protected]> * nest raise if exc Signed-off-by: Yee Hing Tong <[email protected]> * added keyring.alt for tests Signed-off-by: Ketan Umare <[email protected]> * updated Signed-off-by: Ketan Umare <[email protected]> * updated Signed-off-by: Ketan Umare <[email protected]> * Lint Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Ketan Umare <[email protected]> Signed-off-by: Ketan Umare <[email protected]> Signed-off-by: Ketan Umare <[email protected]> Signed-off-by: Ketan Umare <[email protected]> Signed-off-by: Yee Hing Tong <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Ketan Umare <[email protected]> Co-authored-by: Ketan Umare <[email protected]> Co-authored-by: Ketan Umare <[email protected]> Co-authored-by: Yee Hing Tong <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> * Remove requirements files (#1511) * Remove mentions to spark Signed-off-by: Eduardo Apolinario <[email protected]> * Remove mentions to requirements.txt and dev-requirements.txt Signed-off-by: Eduardo Apolinario <[email protected]> * Remove plugins requirements. Signed-off-by: Eduardo Apolinario <[email protected]> * Remove all_requirements target from plugins makefile Signed-off-by: Eduardo Apolinario <[email protected]> * Use dev-requirements.in in lint gh action job Signed-off-by: Eduardo Apolinario <[email protected]> * Revert "Remove all_requirements target from plugins makefile" This reverts commit 50cbb4d. Signed-off-by: Eduardo Apolinario <[email protected]> * Revert "Remove plugins requirements." This reverts commit eae945c. Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> * Remove requirements files (#1511) * Remove mentions to spark Signed-off-by: Eduardo Apolinario <[email protected]> * Remove mentions to requirements.txt and dev-requirements.txt Signed-off-by: Eduardo Apolinario <[email protected]> * Remove plugins requirements. Signed-off-by: Eduardo Apolinario <[email protected]> * Remove all_requirements target from plugins makefile Signed-off-by: Eduardo Apolinario <[email protected]> * Use dev-requirements.in in lint gh action job Signed-off-by: Eduardo Apolinario <[email protected]> * Revert "Remove all_requirements target from plugins makefile" This reverts commit 50cbb4d. Signed-off-by: Eduardo Apolinario <[email protected]> * Revert "Remove plugins requirements." This reverts commit eae945c. Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Ketan Umare <[email protected]> Signed-off-by: Ketan Umare <[email protected]> Signed-off-by: Ketan Umare <[email protected]> Signed-off-by: Ketan Umare <[email protected]> Signed-off-by: Yee Hing Tong <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Ketan Umare <[email protected]> Co-authored-by: Ketan Umare <[email protected]> Co-authored-by: Ketan Umare <[email protected]> Co-authored-by: Ketan Umare <[email protected]> Co-authored-by: Yee Hing Tong <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Remove mentions to requirements.txt and dev-requirements.txt
Type
Are all requirements met?
Complete description
Up to this point we operated under the assumption that maintaining a single set of requirements files would be enough. This would guarantee a semblance of reproducibility (since we would be able to reproduce the environment used for that change). That assumption broke down as we started seeing libraries not being available in all OS+architecture we support, for example,
tensorflow
does not install cleanly on Mac M1's.In this change we trade reproducibility for the maintenance burden of having exhaustive requirements files by environment. jazzband/pip-tools#826 (comment) is the current advice coming from
pip-tools
, basically if we are to do this we need to runpip-tools
once per-environment.Instead, we're taking one step back in order to figure out what's the right next steps. The idea is that we're going to invest in a real multi-environment solution in the near future, but in the meanwhile, we're going to lose reproducibility in order to decrease the maintenance burden. Note that this change is going to subsume the need for #1424.
As a side-note, we removed the legacy
all-spark
extras in #807, but never removed the CI bits related to the spark-2.4 extra. Those are being removed in this PR.Tracking Issue
flyteorg/flyte#3284
Follow-up issue
NA