WIP - Detect if running on a Mac M1 and use appropriate dev-requirements file #1424
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eduardo Apolinario [email protected]
Fixes flyteorg/flyte#3264
TL;DR
Special case Mac M1/2's in the case of dev environment
Type
Are all requirements met?
Complete description
In this PR the make targets related to the dev environment detect if the user's platform. We introduce a new dev-requirements file produced on a Mac M1.
Testing:
make dev-requirements.txt
on a M1 and push a commit to this PR with the contents of thedev-requirements-mac_arm64.txt
file.make setup
on a new venvTracking Issue
flyteorg/flyte#3264
Follow-up issue
NA