Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Config] Port 'RCNConfigSettings' #14262

Open
wants to merge 17 commits into
base: rc-swift
Choose a base branch
from
Open

[Config] Port 'RCNConfigSettings' #14262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
e8a5155
[Config] Port 'RCNConfigSettings'
ncooke3 Dec 16, 2024
4b9fedf
[Config] Port 'RCNConfigSettings' (1)
ncooke3 Dec 16, 2024
7619069
Small fixes
ncooke3 Dec 16, 2024
4730b6e
Remove WIP files
ncooke3 Dec 16, 2024
f1f655b
Add optional param
ncooke3 Dec 16, 2024
ccdf0d6
Add todo
ncooke3 Dec 16, 2024
f62785f
Comments
ncooke3 Dec 16, 2024
105d57f
Add note comments
ncooke3 Dec 16, 2024
7c00a01
Remove implicit optionals
ncooke3 Dec 16, 2024
9ca31b1
Resolve warning
ncooke3 Dec 16, 2024
db204ed
Fix doc comment
ncooke3 Dec 16, 2024
1602fbb
Remove unused vars
ncooke3 Dec 17, 2024
45e4a95
Make class public
ncooke3 Dec 17, 2024
3ad0066
Review + extra cleanup
ncooke3 Dec 17, 2024
d63759b
Fix test failure
ncooke3 Dec 17, 2024
949168d
Add atomic TODOs
ncooke3 Dec 17, 2024
55a7d9d
Fix unit test
ncooke3 Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion FirebaseRemoteConfig/Sources/FIRRemoteConfig.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
#import "FirebaseRemoteConfig/Sources/Private/FIRRemoteConfig_Private.h"
#import "FirebaseRemoteConfig/Sources/Private/RCNConfigFetch.h"
#import "FirebaseRemoteConfig/Sources/Private/RCNConfigSettings.h"
#import "FirebaseRemoteConfig/Sources/RCNConfigConstants.h"
#import "FirebaseRemoteConfig/Sources/RCNConfigRealtime.h"
#import "FirebaseRemoteConfig/Sources/RCNPersonalization.h"
Expand Down
1 change: 0 additions & 1 deletion FirebaseRemoteConfig/Sources/Private/FIRRemoteConfig_Private.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
*/

#import <FirebaseRemoteConfig/FIRRemoteConfig.h>
#import "RCNConfigSettings.h" // This import is needed to expose settings for the Swift API tests.

@class FIROptions;
@class RCNConfigContent;
Expand Down
152 changes: 0 additions & 152 deletions FirebaseRemoteConfig/Sources/Private/RCNConfigSettings.h
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion FirebaseRemoteConfig/Sources/RCNConfigFetch.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
#import <GoogleUtilities/GULNSData+zlib.h>
#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
#import "FirebaseInstallations/Source/Library/Private/FirebaseInstallationsInternal.h"
#import "FirebaseRemoteConfig/Sources/Private/RCNConfigSettings.h"
#import "FirebaseRemoteConfig/Sources/RCNConfigConstants.h"

#import "FirebaseRemoteConfig/FirebaseRemoteConfig-Swift.h"
Expand Down
1 change: 0 additions & 1 deletion FirebaseRemoteConfig/Sources/RCNConfigRealtime.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
#import "FirebaseInstallations/Source/Library/Private/FirebaseInstallationsInternal.h"
#import "FirebaseRemoteConfig/FirebaseRemoteConfig-Swift.h"
#import "FirebaseRemoteConfig/Sources/Private/RCNConfigFetch.h"
#import "FirebaseRemoteConfig/Sources/Private/RCNConfigSettings.h"
#import "FirebaseRemoteConfig/Sources/RCNConfigConstants.h"

/// URL params
Expand Down
Loading
Loading