Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Config] Port 'RCNConfigSettings' #14262

Open
wants to merge 17 commits into
base: rc-swift
Choose a base branch
from
Open

[Config] Port 'RCNConfigSettings' #14262

wants to merge 17 commits into from

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Dec 16, 2024

#no-changelog

@ncooke3 ncooke3 marked this pull request as draft December 16, 2024 21:09
@ncooke3 ncooke3 marked this pull request as ready for review December 16, 2024 23:16
@ncooke3 ncooke3 requested a review from paulb777 December 16, 2024 23:16
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this tvos pll test failure actionable?

- NOTE  | [tvOS] xcodebuild:  /Users/runner/work/firebase-ios-sdk/firebase-ios-sdk/FirebaseRemoteConfig/Tests/Unit/RCNRemoteConfigTest.m:1514: error: -[RCNRemoteConfigTest testFetchRequestWithUserPropertiesOnly] : (([req containsString:@"analytics_user_properties:{\"user_key\":\"user_value\"}"]) is true) failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants