Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove is_async support #2344

Merged
merged 3 commits into from
Sep 27, 2024
Merged

chore: remove is_async support #2344

merged 3 commits into from
Sep 27, 2024

Conversation

CaselIT
Copy link
Member

@CaselIT CaselIT commented Sep 27, 2024

Fixes: #2343

@CaselIT CaselIT requested a review from vytas7 September 27, 2024 18:33
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0c24a18) to head (dfbe507).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2344   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           64        64           
  Lines         7621      7621           
  Branches      1242      1244    +2     
=========================================
  Hits          7621      7621           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vytas7 vytas7 changed the title Remove is_async chore: remove is_async support Sep 27, 2024
Copy link
Member

@vytas7 vytas7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM bar the newsfragment that probably needs minor polishing, but I can take a look in the alpha PR (and we are even not rendering the newsfragments out yet).

@vytas7 vytas7 merged commit ec13858 into falconry:master Sep 27, 2024
37 checks passed
@CaselIT CaselIT deleted the by_is_async branch September 29, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for is_async without a deprecation window
2 participants