Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for is_async without a deprecation window #2343

Closed
vytas7 opened this issue Sep 27, 2024 · 0 comments · Fixed by #2344
Closed

Remove support for is_async without a deprecation window #2343

vytas7 opened this issue Sep 27, 2024 · 0 comments · Fixed by #2344

Comments

@vytas7
Copy link
Member

vytas7 commented Sep 27, 2024

Normally, we always give an adequate deprecation window when removing features, even if it is a major release.

However, the is_async parameter (used for hooks and media validation) represents an edge case where I very much doubt that anyone from the community has ever needed this flag.

What is more, very easy workarounds exist: wrapping the method in question inside an async def, or even easier, simply using inspect.markcoroutinefunction() (on CPython 3.12+) to mark the method as such. In addition, Cython 3.0 (on CPython 3.10+) no longer needs this flag, as it is able to convey the information to the interpreter via setting the appropriate code flags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants