Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] comment out mmf references #80

Merged
merged 2 commits into from
Sep 11, 2020
Merged

[docs] comment out mmf references #80

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
502f2ab
[docs] comment out mmf references
Sep 11, 2020
832067d
fix lint error
Sep 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/source/_templates/layout.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@
<meta property="og:title" content="{{ title|striptags|e }}{{ titlesuffix }}">
<meta name="description" content="{{ theme_variables.og['description'] }}">
<meta property="og:description" content="{{ theme_variables.og['description'] }}">
<meta property="og:image" content="https://mmf.sh/img/logo.png">
<meta property="twitter:image" content="https://mmf.sh/img/logo.png">
<!--<meta property="og:image" content="https://mmf.sh/img/logo.png">-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious, why not delete it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I left it as a placeholder so that I wouldn't forget how to implement this feature once we had a logo. The file currently very messy. When I clean it up, I will remove.

<!--<meta property="twitter:image" content="https://mmf.sh/img/logo.png">-->
<meta name="twitter:image:alt" content="Image for fairscale">
<meta name="twitter:card" content="summary_large_image">
{# CSS #}
Expand Down
3 changes: 1 addition & 2 deletions docs/source/conf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@


html_theme = "pytorch_sphinx_theme"
html_theme_path = [pytorch_sphinx_theme.get_html_theme_path()]
templates_path = ["_templates"]

# Add any paths that contain custom static files (such as style sheets) here,
Expand All @@ -64,7 +63,7 @@
#
html_theme_options = {
"includehidden": False,
"canonical_url": "https://mmf.sh/api/",
"canonical_url": "https://fairscale.readthedocs.io",
"pytorch_project": "docs",
}

Expand Down