[docs] comment out mmf references #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updated canonical_url to be fairscale. Also removed unnecessary htmi_theme_path.
facebook-github-bot
added
the
CLA Signed
min-xu-ai
approved these changes
Sep 11, 2020
| @@ -30,8 +30,8 @@ | |||
| <meta property="og:title" content="{{ title|striptags|e }}{{ titlesuffix }}"> | |||
| <meta name="description" content="{{ theme_variables.og['description'] }}"> | |||
| <meta property="og:description" content="{{ theme_variables.og['description'] }}"> | |||
| <meta property="og:image" content="https://mmf.sh/img/logo.png"> | |||
| <meta property="twitter:image" content="https://mmf.sh/img/logo.png"> | |||
| <!--<meta property="og:image" content="https://mmf.sh/img/logo.png">--> | |||
There was a problem hiding this comment.
just curious, why not delete it?
There was a problem hiding this comment.
I guess I left it as a placeholder so that I wouldn't forget how to implement this feature once we had a logo. The file currently very messy. When I clean it up, I will remove.
myleott
pushed a commit
that referenced
this pull request
Feb 22, 2021
* added uneven shard unit test * updates * fixed * change the inputs * skip torch 1.5 * merged after renaming * add assert output * overlly small param test * fixed the overly small param corner case * another issue with _calc_num_to_pad * one more fix * a lot of more test cases and simplified the sharding logic, but still not fully right * make sure we cover 8 GPUs too, run more than one iter for the smaller param test * byte -> element * fixing an assert in the test * add a todo comment * moved compute_shard_size into a separate module and added unit test * fixed the issue of free_storage * clean up * two more bugs * one more bug * one more bug * not more F.pad() in reduce_scatter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updated canonical_url to be fairscale.
Also removed unnecessary htmi_theme_path.
Before submitting
What does this PR do?
Fixes # (issue).
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃