Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.16 #3423

Merged
merged 26 commits into from
Sep 28, 2017
Merged

Release 4.16 #3423

merged 26 commits into from
Sep 28, 2017

Conversation

dougwilson
Copy link
Contributor

@dougwilson dougwilson commented Sep 25, 2017

This is a tracking issue for release 4.16.

Please keep feature requests in their own issues

If you want to make a comment on a particular change, please make the comment in the "Files changed" tab so comments are not lost during a rebase.

List of changes for release:

Testing this release

If you want to try out this release, you can install it with the following commands:

$ npm cache clean express
$ npm install expressjs/express#4.16

Owners/collaborators: please do not merge this PR :)

@dougwilson
Copy link
Contributor Author

Due to #3432 I'm likely going to cut another 4.15 release, which means I'll need to rebase this again, though I still haven't finished the rebase from the first security injection :)

I also looked harder at the mime dependency on if there is any possible way to get it into a new 4.15 release, but that does not seem feasible without violating semver, since it would be a lot of work (almost to re-implementing mime) to undo the semver changes that was included in the release.

Getting a new mime 1.3.x is also not workable, because we are on 1.3.4 and one of the patch versions above that includes a change that is semver-minor to us, so there isn't a version number available for a surgical 1.3.x release of mime for us anyway.

@dougwilson
Copy link
Contributor Author

Due to the influx of issues related to mime and the logistics of getting forwarded to no longer include < 0.1.2 in the semver range, I think this release should be accelerated, which will likely mean not including changes that were originally slated for 4.16 in order to get it out the door. This should allow a quality release of 4.16 shipped Thursday Sep 28 instead of Monday Oct 2.

@LinusU
Copy link
Member

LinusU commented Sep 28, 2017

Just read thru the entire changeset and it looks stellar ✨ just in case you wanted another pair of 👀 on it 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants