Request for request #3327, allowing res.download to supply options to res.sendFile #3370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chillypepper
commented
Jul 20, 2017
chillypepper
commented
- Added an "options" field to res.download, allowing for options to be passed into sendFile
- Options will include the existing Content-Disposition header by default, unless explicit headers are provided
- Added tests for the new res.download functionality - with blank options, with allowed dotfiles, and with a custom Content-Disposition
…e passed into sendFile - Options will include the existing Content-Disposition header by default, unless explicit headers are provided - Added tests for the new res.download functionality - with blank options, with allowed dotfiles, and with a custom Content-Disposition
dougwilson
suggested changes
Jul 20, 2017
… rather than be overriden by them - Included a note in the function docs recommending res.sendFile if this behaviour doesn't meet the use case - Modififed a test for res.download to check for the existence of merged headers
… provided Content-Disposition will be overridden - Function docs and test case for provided Content-Disposition have been updated to reflect this
|
I've chosen to follow option 2 from the thread, "Merge the headers, where the generated content-disposition overwrites whatever the user gave." Ignore that quick commit in the middle hahaha, it should all work nicely now. Thanks for your help with this! |
dougwilson
approved these changes
Sep 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.