-
-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Knapsack: Make Bob a Sherpa #2470
Knapsack: Make Bob a Sherpa #2470
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a much better scenario!
For people unfamiliar with the term, let's add a link. Maybe https://en.wikipedia.org/wiki/Sherpa_people#Mountaineering |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Locking this down so it's not merged before we change the icon and so that we don't end up in the scenario that @mk-mxp warned of where we use a thief icon for Sherpas :)
If this is still unresolved by the end of August (ie I've not fixed the icon), please nudge me on the forum or Discord. Thanks!
Should we use a more Sherpa name, rather than "Bob"? Does this affect the exercise etc? Maybe "Lhakpa" in honour of https://www.imdb.com/title/tt28448182/ and change the gender references to female? |
Kami? This is the current record holder: https://en.wikipedia.org/wiki/Kami_Rita
Good idea, Ming is also pretty cool, as she did it with such a young age: https://en.wikipedia.org/wiki/Ming_Kipa |
I think I'll go with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the new version, thanks for the changes
I shouldn't have merged this, sorry! Please don't yet sync this to your tracks, we still need the icon to be updated. |
This reverts commit d29e719.
As discussed in the forum, being a sherpa is much more legal than being a thief.