Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knapsack: Make Bob a Sherpa #2470

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

mk-mxp
Copy link
Contributor

@mk-mxp mk-mxp commented Aug 13, 2024

As discussed in the forum, being a sherpa is much more legal than being a thief.

@mk-mxp mk-mxp requested a review from a team as a code owner August 13, 2024 12:06
@mk-mxp mk-mxp self-assigned this Aug 13, 2024
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a much better scenario!

@glennj
Copy link
Contributor

glennj commented Aug 13, 2024

For people unfamiliar with the term, let's add a link. Maybe https://en.wikipedia.org/wiki/Sherpa_people#Mountaineering

Copy link
Member

@iHiD iHiD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locking this down so it's not merged before we change the icon and so that we don't end up in the scenario that @mk-mxp warned of where we use a thief icon for Sherpas :)

If this is still unresolved by the end of August (ie I've not fixed the icon), please nudge me on the forum or Discord. Thanks!

@iHiD
Copy link
Member

iHiD commented Aug 13, 2024

Should we use a more Sherpa name, rather than "Bob"? Does this affect the exercise etc?

Maybe "Lhakpa" in honour of https://www.imdb.com/title/tt28448182/ and change the gender references to female?

@vaeng
Copy link
Contributor

vaeng commented Aug 14, 2024

Should we use a more Sherpa name, rather than "Bob"? Does this affect the exercise etc?

Kami? This is the current record holder: https://en.wikipedia.org/wiki/Kami_Rita

Maybe "Lhakpa" in honour of https://www.imdb.com/title/tt28448182/ and change the gender references to female?

Good idea, Ming is also pretty cool, as she did it with such a young age: https://en.wikipedia.org/wiki/Ming_Kipa

@mk-mxp
Copy link
Contributor Author

mk-mxp commented Aug 15, 2024

Should we use a more Sherpa name, rather than "Bob"? Does this affect the exercise etc?

Kami? This is the current record holder: https://en.wikipedia.org/wiki/Kami_Rita

Maybe "Lhakpa" in honour of https://www.imdb.com/title/tt28448182/ and change the gender references to female?

Good idea, Ming is also pretty cool, as she did it with such a young age: https://en.wikipedia.org/wiki/Ming_Kipa

I think I'll go with Lhakpa is a [Sherpa][sherpa] mountain guide and porter. and adjust to that.

Copy link
Contributor

@vaeng vaeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new version, thanks for the changes

@mk-mxp mk-mxp changed the title Knapsack: Make Bob a sherpa Knapsack: Make Bob a Sherpa Aug 15, 2024
@mk-mxp mk-mxp requested review from glennj and IsaacG August 15, 2024 14:28
@ErikSchierboom ErikSchierboom merged commit d29e719 into exercism:main Aug 16, 2024
7 checks passed
@ErikSchierboom
Copy link
Member

I shouldn't have merged this, sorry! Please don't yet sync this to your tracks, we still need the icon to be updated.

ErikSchierboom added a commit that referenced this pull request Aug 16, 2024
ErikSchierboom added a commit that referenced this pull request Aug 16, 2024
ErikSchierboom added a commit that referenced this pull request Aug 16, 2024
@mk-mxp mk-mxp deleted the knapsack-make-bob-a-sherpa branch September 1, 2024 04:31
ErikSchierboom added a commit that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants