Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Knapsack: Make Bob a Sherpa"" #2473

Merged

Conversation

ErikSchierboom
Copy link
Member

Reverts #2472

Sorry about all this!

@ErikSchierboom ErikSchierboom marked this pull request as ready for review September 5, 2024 14:12
@ErikSchierboom ErikSchierboom requested a review from a team as a code owner September 5, 2024 14:12
@IsaacG
Copy link
Member

IsaacG commented Sep 7, 2024

The icon issue has been resolved.

@ErikSchierboom
Copy link
Member Author

I'm still seeing the old icon when I view https://assets.exercism.org/exercises/knapsack.svg @IsaacG do you see the new one?

@IsaacG
Copy link
Member

IsaacG commented Sep 9, 2024

I'm still seeing the old icon when I view https://assets.exercism.org/exercises/knapsack.svg @IsaacG do you see the new one?

I'm seeing the old one. Should exercism/website-icons#181 be reopened?

@ErikSchierboom
Copy link
Member Author

It's a cache invalidation issue. It's weird, because it should be invalidated:

{
    "Location": "https://cloudfront.amazonaws.com/2020-05-31/distribution/E2UP4JZ9NOWLGP/invalidation/I3NIWLRGKIS3WUJE5UAXQBMPUY",
    "Invalidation": {
        "Id": "I3NIWLRGKIS3WUJE5UAXQBMPUY",
        "Status": "InProgress",
        "CreateTime": "2024-09-05T06:11:42.471000+00:00",
        "InvalidationBatch": {
            "Paths": {
                "Quantity": 1,
                "Items": [
                    "/exercises/knapsack.svg"
                ]
            },
            "CallerReference": "cli-17255[16](https://github.com/exercism/website-icons/actions/runs/10714872114/job/29709310703#step:7:17)702-237545"
        }
    }
}

as per https://github.com/exercism/website-icons/actions/runs/10714872114/job/29709310703

@ErikSchierboom
Copy link
Member Author

I've tried manually running the invalidation, but it doesn't seem to work: https://assets.exercism.org/exercises/knapsack.svg

@ErikSchierboom
Copy link
Member Author

I'll let @iHiD look into this when he has time.

@Cool-Katt
Copy link
Contributor

I know this is an old issue but I just checked and the new icon is showing on the site, so I suppose this can be closed.
Also, the text is unchanged so it still has references to Bob being a thief. @ErikSchierboom

@ErikSchierboom ErikSchierboom merged commit 06116af into main Dec 4, 2024
8 checks passed
@ErikSchierboom ErikSchierboom deleted the revert-2472-revert-2470-knapsack-make-bob-a-sherpa branch December 4, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants