Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devnet: devnet-test and CI improvements #7788

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Conversation

protolambda
Copy link
Contributor

@protolambda protolambda commented Oct 23, 2023

General improvement for a faster devnet CI job.
This reduces the devnet time from ~16-18 min to ~6-7 min. (note: some of the docker build improvements are used already, and improving more in separate PRs like #7811 )

Changes:

  • Set devnet recommit time to 100ms, so tx-inclusion is not delayed by a block
  • Avoid docker-build: we already load the images from the workspace, built by the previous job. We can run the devnet with those.
  • Change the devnet python script to run the hardhat tests in parallel: this required adding an extra test option to select the signer, and hardhat configuration to support more devnet signers, to avoid conflicts between tests (running on the same network, thus need different accounts to have no nonce-increment race conditions).
  • Increase the devnet L2 output submission interval from 6 L2 blocks to 10 L2 blocks. This makes the proposer fall behind less (it needs to wait for batcher and confirm txs already, which takes more than 6 seconds), and by not falling behind the test is faster. We might want to bump this number up higher later.

@protolambda protolambda force-pushed the devnet-ci-speed branch 4 times, most recently from ca7597f to 3ef7fd1 Compare October 24, 2023 17:59
@protolambda protolambda changed the title devnet: CI speed experiment devnet: devnet-test and CI improvements Oct 25, 2023
@protolambda protolambda marked this pull request as ready for review October 25, 2023 16:04
@protolambda protolambda requested review from a team as code owners October 25, 2023 16:04
@protolambda protolambda requested review from ajsutton and tynes October 25, 2023 16:04
@tynes tynes enabled auto-merge October 25, 2023 18:48
@tynes tynes added this pull request to the merge queue Oct 25, 2023
@protolambda protolambda removed this pull request from the merge queue due to a manual request Oct 25, 2023
@protolambda protolambda added this pull request to the merge queue Oct 25, 2023
@protolambda
Copy link
Contributor Author

Re-added to merge queue. The merge-queue job failed, and wasn't letting the next PR go through, stuck on CI status report. It flaked on 4 cannon tests in op-e2e.

Merged via the queue into develop with commit 64a28a8 Oct 26, 2023
4 checks passed
@protolambda protolambda deleted the devnet-ci-speed branch October 26, 2023 00:10
nitaliano pushed a commit that referenced this pull request May 20, 2024
devnet: devnet-test and CI improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants