-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ops,ci: docker buildx bake, fix publish/release flows #7811
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI workflow is now failing. I'm not sure why, but it's in the op-stack-go-docker-build-1
step and looks like it's caused by these changes.
460842c
to
3ffe7fc
Compare
c3c7a79
to
5d68d58
Compare
67c36d6
to
6856420
Compare
8ac6b6b
to
de78eb2
Compare
de78eb2
to
8358328
Compare
As long as we are ok with depending on an experimental feature, i am cool with this |
Description
In #7715 we changed the docker build system to build the following modules with a shared docker image, to reduce CI work and improve cache usage:
Most of these we also publish (everything except op-wheel), and release (everything except op-program and op-wheel).
However, we were building the same docker images with 3 different job definitions that then had to correctly invoke the docker build.
To try and fix that, I unified the
docker_build
/docker_publish
/docker_release
jobs, since most of the parameters and work overlaps.With new
publish
andrelease
job parameters (boolean flags) the job can do the steps for publishing/releasing conditionally.And to reduce the CI configuration more, I moved the docker configuration of all the targets into a docker-bake setup (see
docker-bake.hcl
): seemake golang-docker
for an example that builds the commonop-node op-batcher op-proposer op-challenger
targets.